Update formatting for source and header files #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
changed the title
added 4 commits
June 22, 2023 01:56
Signed-off-by: ilya.kuksenok <[email protected]>
Signed-off-by: ilya.kuksenok <[email protected]>
Signed-off-by: ilya.kuksenok <[email protected]>
Signed-off-by: ilya.kuksenok <[email protected]>
|
@giuseppe could you review this pr? |
flouthoc
reviewed
Jun 22, 2023
flouthoc
reviewed
Jun 22, 2023
|
@Ilya-source thanks for opening the PR, could you please open a PR for crun that uses this version of libocispec to see if there are any regressions? |
|
actually we don't need that, I've verified the generated source is the same |
That makes code a bit easier to debug in python debugger, and this is faster, of course, in this project this was not that important, because this is just a one time generation step, but still. :) |
|
@Ilya-source Thanks for the info and the PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I want to introduce some updates to string handling: move from %s formatting to f-string.
That makes the code a bit more readable and faster.
Also, I changed how source and header files are written (basically, I just moved to the
writelinesmethod).I hope you will find those changes useful.